fix: skip validation of START_EPOCH env variable
#212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the Altair epoch is different in different testnets, it is not possible to set a static pre-defined number of the `START_EPOCH` as a required minimum value of this variable. So, for now, we skip the validation of this env variable on testnets. Later it would be better to implement a custom validation directive for validating the minimum possible value of the `START_EPOCH` variable depending on the testnet where the application is running.
vgorkavenko
reviewed
Oct 17, 2023
Remove checking that prevents validation of the `START_EPOCH` environment variable value in the test environment. So, now the validation rules for this variable become stronger.
infloop
approved these changes
Oct 18, 2023
vgorkavenko
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Altair epoch is different in different testnets, it is not possible to set a static pre-defined number of the
START_EPOCHas a required minimum value of this variable. So, for now, we skip the validation of this env variable on testnets.Later it would be better to implement a custom validation directive for validating the minimum possible value of the
START_EPOCHvariable depending on the testnet where the application is running.