Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner about deprecated hash for ipfs version #190

Merged
merged 22 commits into from
Feb 20, 2024
Merged

Banner about deprecated hash for ipfs version #190

merged 22 commits into from
Feb 20, 2024

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Dec 15, 2023 •
edited
Loading

Description

  • Added hook to extract CID and compare with github one
  • implement banner with link to update

Demo

image

Testing notes

  • test that this does not appear on infra version
  • we need to add IPFS.json in separate PR and push to main
  • deploy this to IPFS and see that banner has appeared

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

Jeday and others added 10 commits December 14, 2023 18:34
@Jeday Jeday marked this pull request as ready for review February 13, 2024 13:05
@Jeday Jeday requested review from a team as code owners February 13, 2024 13:05
@preview-stands
Copy link

preview-stands bot commented Feb 13, 2024 •
edited
Loading

Preview stand status

Stand was demolished

Tarens2
Tarens2 previously approved these changes Feb 14, 2024
View reviewed changes
Jeday and others added 4 commits February 15, 2024 16:41
@Jeday
build: add IPFS manifest
933583a
@Jeday
Merge branch 'feature/si-1122-banner-about-deprecated-hash-for-ipfs-v…
75ad32a 
…ersion' of github.com:lidofinance/ethereum-staking-widget into feature/si-1122-banner-about-deprecated-hash-for-ipfs-version
@Jeday
Merge branch 'develop' into feature/si-1122-banner-about-deprecated-h…
1ddf38c 
…ash-for-ipfs-version
@Jeday
fix: add warning comment
7eaf200
@Jeday
Merge branch 'feature/si-1122-banner-about-deprecated-hash-for-ipfs-v…
ef61176 
…ersion' of github.com:lidofinance/ethereum-staking-widget into feature/si-1122-banner-about-deprecated-hash-for-ipfs-version
DiRaiks
DiRaiks previously approved these changes Feb 15, 2024
View reviewed changes
solidovic
solidovic previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@solidovic solidovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is not blocked comment.

@Jeday Jeday dismissed stale reviews from solidovic and DiRaiks via b35b27e February 15, 2024 11:27
solidovic
solidovic previously approved these changes Feb 15, 2024
View reviewed changes
solidovic
solidovic previously approved these changes Feb 15, 2024
View reviewed changes
DiRaiks
DiRaiks previously approved these changes Feb 16, 2024
View reviewed changes
@solidovic solidovic dismissed stale reviews from DiRaiks and themself via af711aa February 19, 2024 11:17
@solidovic solidovic mentioned this pull request Feb 19, 2024
Merged
1 task
@jake4take jake4take merged commit 9ff174e into develop Feb 20, 2024
8 checks passed
@jake4take jake4take deleted the feature/si-1122-banner-about-deprecated-hash-for-ipfs-version branch February 20, 2024 10:22
@jake4take jake4take mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jake4take jake4take jake4take approved these changes

@DiRaiks DiRaiks DiRaiks approved these changes

@solidovic solidovic solidovic approved these changes

@Tarens2 Tarens2 Tarens2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jeday @solidovic @Tarens2 @DiRaiks @jake4take