Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace REQUEST_BURN_SHARES_ROLE with REQUEST_BURN_MY_STETH_ROLE for All Staking Modules #871

Open
2 tasks done
mkurayan opened this issue Nov 11, 2024 · 0 comments
Open
2 tasks done
Labels
enhancement New feature or request

Comments

@mkurayan
Copy link
Contributor

Summary

Currently, all staking modules have the REQUEST_BURN_SHARES_ROLE role in the Burner contract, which allows the caller to lock stETH from any address that has pre-approved an amount of stETH for burning, but staking modules must only lock stETH from their contract address. Therefore, staking modules can use the less powerful REQUEST_BURN_MY_STETH_ROLE role.

Problem

The 'REQUEST_BURN_SHARES_ROLE' grants staking modules excessive permissions beyond what is necessary, violating the principle of granting only the minimum required permissions.

Implementation

It is recommended to remove the REQUEST_BURN_SHARES_ROLE from all staking modules and grant them the REQUEST_BURN_MY_STETH_ROLE instead.

This change will require minimal contract code modifications but will enhance module isolation and protocol security.

Guidelines

@mkurayan mkurayan added the enhancement New feature or request label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant