Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: l2-bridge-base moved 🚨🚨🚨 Base bridge balance mismatch 🚨🚨🚨from l… #527

Merged
merged 3 commits into from
Apr 11, 2024
Merged

fix: l2-bridge-base moved 🚨🚨🚨 Base bridge balance mismatch 🚨🚨🚨from l… #527

merged 3 commits into from
Apr 11, 2024

Conversation

sergeyWh1te
Copy link
Contributor

@sergeyWh1te sergeyWh1te commented Apr 11, 2024 •
edited
Loading

Part of #526

@sergeyWh1te sergeyWh1te requested review from a team as code owners April 11, 2024 13:10
@sergeyWh1te sergeyWh1te mentioned this pull request Apr 11, 2024
Open
6 tasks
TheDZhon
TheDZhon previously approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a few nitpicks

l2-bridge-base/src/app.ts Show resolved Hide resolved
l2-bridge-base/src/utils/constants.ts Outdated
Comment on lines 14 to 18
WSTETH_ADDRESS: string
BASE_L1ERC20_TOKEN_BRIDGE: string
GOV_BRIDGE_ADDRESS: string
L2_ERC20_TOKEN_GATEWAY_ADDRESS: string
BASE_WST_ETH_BRIDGED_ADDRESS: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WSTETH_ADDRESS: string
BASE_L1ERC20_TOKEN_BRIDGE: string
GOV_BRIDGE_ADDRESS: string
L2_ERC20_TOKEN_GATEWAY_ADDRESS: string
BASE_WST_ETH_BRIDGED_ADDRESS: string
L1_WSTETH_ADDRESS: string
BASE_L1ERC20_TOKEN_BRIDGE: string
GOV_BRIDGE_ADDRESS: string
L2_ERC20_TOKEN_GATEWAY_ADDRESS: string
L2_WSTETH_ADDRESS: string

TheDZhon
TheDZhon approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheDZhon TheDZhon merged commit 4736473 into main Apr 11, 2024
5 checks passed
@TheDZhon TheDZhon deleted the base-balance-mismatch branch April 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeyWh1te @TheDZhon