Add conditional break in parsing the script after op return… #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so long as we are not in a conditional block. This is to get the library in line with v1.0.15.1 of SV node as outlined within this issue: bitcoin-sv/bitcoin-sv#296 Logic should match SV node here: https://github.com/bitcoin-sv/bitcoin-sv/blob/89d55a8ddb0e29f4786e11efad1e92cdefd0b9c5/src/script/script.cpp#L38 Signed-off-by: Darren Kellenschwiler <[email protected]>
Signed-off-by: Darren Kellenschwiler <[email protected]>
|
Hello @sirdeggen |
|
@boecklim is Farzan available to get that test written this week? I'm not, but keen to get this in asap. |
boecklim
approved these changes
Aug 28, 2023
ordishs
pushed a commit
to ordishs/go-bt
that referenced
this pull request
Sep 5, 2023
* Added conditional break in parsing the script after op return… … so long as we are not in a conditional block. This is to get the library in line with v1.0.15.1 of SV node as outlined within this issue: bitcoin-sv/bitcoin-sv#296 Logic should match SV node here: https://github.com/bitcoin-sv/bitcoin-sv/blob/89d55a8ddb0e29f4786e11efad1e92cdefd0b9c5/src/script/script.cpp#L38 Signed-off-by: Darren Kellenschwiler <[email protected]> * typo Signed-off-by: Darren Kellenschwiler <[email protected]> * Add unit test for Parse function --------- Signed-off-by: Darren Kellenschwiler <[email protected]> Co-authored-by: Michael Boeckli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…so long as we are not in a conditional block.
This is to get the library in line with v1.0.15.1 of SV node as outlined within this issue: bitcoin-sv/bitcoin-sv#296
Logic should match SV node here: https://github.com/bitcoin-sv/bitcoin-sv/blob/89d55a8ddb0e29f4786e11efad1e92cdefd0b9c5/src/script/script.cpp#L38