This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
bottomless-cli: add verify command
#744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way create_dir_all() is called on a path to the database, it also creates the final file name as a directory. As a result, restoration later fails, because `data.tmp` cannot be moved to `data`, with `data` being already mistakenly created as a directory.
The command works similarly to `restore`, except it restores to a temporary directory and runs a `pragma integrity_check` query. On success it should return: ``` bottomless-cli -e http://localhost:9000 -n ns-:default -d e4e57664-01ad-76cc-9f19-a96700d5b2e4 verify Snapshot size: 13512704 Verification: ok ```
penberg
approved these changes
Oct 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command works similarly to
restore, except it restores to a temporary directory and runs apragma integrity_checkquery.On success it should return:
Refs #717