Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

bug: whenever a DB is loaded for the first time, we are checkpointing without virtual WAL methods #765

Open
avinassh opened this issue Oct 12, 2023 · 0 comments

Comments

@avinassh
Copy link
Member

to reproduce: run a fresh instance of sqld (with namespaces enabled) and create a new db by connecting via shell

the buggy code: https://github.com/libsql/sqld/blob/9b61d01/sqld/src/namespace/mod.rs#L689

relevant logs:

2023-10-12T12:55:31.238990Z DEBUG request{method=POST uri=/v2/pipeline version=HTTP/1.1}: sqld::namespace: Checkpointing before initializing bottomless
2023-10-12T12:55:31.239068Z DEBUG request{method=POST uri=/v2/pipeline version=HTTP/1.1}: sqld::replication::primary::logger: wal file doesn't exist, checkpoint not necessary
2023-10-12T12:55:31.239096Z DEBUG request{method=POST uri=/v2/pipeline version=HTTP/1.1}: sqld::namespace: Checkpointed before initializing bottomless
2023-10-12T12:55:31.239152Z DEBUG request{method=POST uri=/v2/pipeline version=HTTP/1.1}: sqld::namespace: Initializing bottomless replication

full logs: https://gist.github.com/avinassh/57d1a08a652b3085807e2cd36d3280d9

internal discussion - https://chiselstrike.slack.com/archives/C05V2DRSS3U/p1697115046418079?thread_ts=1697097311.578049&cid=C05V2DRSS3U

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant