Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

Consider moving to a stream replication for libsql or adding pagination to BatchLogEntries #647

Open
LucioFranco opened this issue Sep 1, 2023 · 1 comment

Comments

@LucioFranco
Copy link
Collaborator

LucioFranco commented Sep 1, 2023

It is possible for larger databases for BatchLogEntries to be large. This will consume a lot of memory and network bandwidth without the ability to apply back pressure (as you would get with discrete smaller messages). We should consider moving the client to either a stream based api or a paginated BatchLogEntries.

For now the temporary fix is to remove the max decoding message size on the client side.

@neubaner
Copy link
Contributor

neubaner commented Sep 2, 2023

@LucioFranco pushed a PR to libsql that might close this! tursodatabase/libsql#350

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants