Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Node 18 fetch() #6

Open
penberg opened this issue Jan 29, 2024 · 1 comment
Open

Switch to Node 18 fetch() #6

penberg opened this issue Jan 29, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@penberg
Copy link
Contributor

penberg commented Jan 29, 2024

The node-fetch package is now ESM-only, which makes it hard to use for @libsql/client, which also compiles to CommonJS. Let's consider switching to Node 18 and using it's fetch() instead.
@penberg penberg added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 29, 2024
@penberg penberg mentioned this issue Jan 29, 2024
Closed
@remiBoudreau remiBoudreau mentioned this issue Jan 29, 2024
Merged
@remiBoudreau
Copy link
Contributor

Thought I'd take a crack at it. See #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@penberg @remiBoudreau