From 82884f72701db1e469d15cf829d8d095492f4d32 Mon Sep 17 00:00:00 2001 From: Katy DeCorah Date: Sun, 17 Dec 2023 11:51:00 -0500 Subject: [PATCH 1/3] Update settings.json --- .vscode/settings.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 6dd289fc..be5943b8 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -2,7 +2,7 @@ "editor.formatOnSave": true, "editor.defaultFormatter": "esbenp.prettier-vscode", "editor.codeActionsOnSave": { - "source.fixAll.eslint": true + "source.fixAll.eslint": "explicit" }, "files.exclude": { "**/.dist": true From 7ff777a7751eaf50ce5b15ac857e18acfe38538a Mon Sep 17 00:00:00 2001 From: Katy DeCorah Date: Sun, 17 Dec 2023 11:52:09 -0500 Subject: [PATCH 2/3] Fix spelling error in function name --- dist/index.js | 4 ++-- src/index.ts | 4 ++-- src/summary.ts | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dist/index.js b/dist/index.js index a827c011..3736f8fb 100644 --- a/dist/index.js +++ b/dist/index.js @@ -35391,7 +35391,7 @@ function mTags({ tags }) { ;// CONCATENATED MODULE: ./src/summary.ts -function summaryMarkown(library, dateFinished) { +function summaryMarkdown(library, dateFinished) { const { BookStatus, BookTitle } = process.env; return `# Updated library @@ -35681,7 +35681,7 @@ async function read() { } library = sortByDate(library); await returnWriteFile(filename, library); - await core.summary.addRaw(summaryMarkown(library, dateFinished)).write(); + await core.summary.addRaw(summaryMarkdown(library, dateFinished)).write(); } catch (error) { (0,core.setFailed)(error); diff --git a/src/index.ts b/src/index.ts index 75d15f85..59ea51c9 100644 --- a/src/index.ts +++ b/src/index.ts @@ -12,7 +12,7 @@ import getBook from "./get-book"; import { getBookStatus, getDates, sortByDate, toArray } from "./utils"; import { checkOutBook } from "./checkout-book"; import { BookStatus } from "./clean-book"; -import { summaryMarkown } from "./summary"; +import { summaryMarkdown } from "./summary"; import returnReadFile from "./read-file"; import { updateBook } from "./update-book"; import { validatePayload } from "./validate-payload"; @@ -123,7 +123,7 @@ export async function read() { library = sortByDate(library); await returnWriteFile(filename, library); - await summary.addRaw(summaryMarkown(library, dateFinished)).write(); + await summary.addRaw(summaryMarkdown(library, dateFinished)).write(); } catch (error) { setFailed(error); } diff --git a/src/summary.ts b/src/summary.ts index cad92815..0164fb64 100644 --- a/src/summary.ts +++ b/src/summary.ts @@ -11,7 +11,7 @@ import { } from "./summary-markdown"; import { capitalize } from "./utils"; -export function summaryMarkown( +export function summaryMarkdown( library: CleanBook[], dateFinished: BookPayload["date-finished"] ): string { From f91858304df7b54c222d7b5a4569044a007ca748 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 19 Dec 2023 16:22:27 -0500 Subject: [PATCH 3/3] Bump github/codeql-action from 2 to 3 (#149) * Bump github/codeql-action from 2 to 3 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/v2...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] * Update snapshots * Update snapshots --------- Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Katy DeCorah --- .github/workflows/codeql-analysis.yml | 6 +-- src/__tests__/index.test.ts | 74 +++++++++++++-------------- 2 files changed, 40 insertions(+), 40 deletions(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 3c9e922d..0c1b8016 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -42,7 +42,7 @@ jobs: # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL - uses: github/codeql-action/init@v2 + uses: github/codeql-action/init@v3 with: languages: ${{ matrix.language }} # If you wish to specify custom queries, you can do so here or in a config file. @@ -53,7 +53,7 @@ jobs: # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). # If this step fails, then you should remove it and run the build manually (see below) - name: Autobuild - uses: github/codeql-action/autobuild@v2 + uses: github/codeql-action/autobuild@v3 # ℹ️ Command-line programs to run using the OS shell. # 📚 https://git.io/JvXDl @@ -67,4 +67,4 @@ jobs: # make release - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@v2 + uses: github/codeql-action/analyze@v3 diff --git a/src/__tests__/index.test.ts b/src/__tests__/index.test.ts index 415fb8f5..a61bd7a2 100644 --- a/src/__tests__/index.test.ts +++ b/src/__tests__/index.test.ts @@ -99,7 +99,7 @@ describe("index", () => { ], [ "BookThumb", - "https://books.google.com/books/content?id=NFeTEAAAQBAJ&printsec=frontcover&img=1&zoom=1&source=gbs_api", + "https://books.google.com/books/content?id=pUmNEAAAQBAJ&printsec=frontcover&img=1&zoom=1&source=gbs_api", ], ] `); @@ -113,7 +113,7 @@ describe("index", () => { ], "description": "NEW YORK TIMES BESTSELLER Winner of the 2020 Center for Fiction First Novel Prize Winner of the 2020 National Book Critics Circle's John Leonard Prize for Best First Book Winner of the 2020 Kirkus Prize for Fiction Winner of the 2021 Dylan Thomas Prize Finalist for the 2021 PEN/Hemingway Award for Best First Novel Longlisted for the 2021 Andrew Carnegie Medal for Excellence in Fiction Longlisted for the 2021 PEN/Jean Stein Book Award Longlisted for the 2021 Women's Prize for Fiction A New York Times Notable Book of the Year Named Best Book of the Year by O: the Oprah Magazine, Vanity Fair, Los Angeles Times, Town and Country, Amazon, Indigo, NPR, Harper’s Bazaar, Kirkus Reviews, Marie Claire, Good Housekeeping Sharp, comic, disruptive, and tender, Luster sees a young Black woman fall into art and someone else's open marriage. Edie is stumbling her way through her twenties—sharing a subpar apartment in Bushwick, clocking in and out of her admin job, making a series of inappropriate sexual choices. She's also, secretly, haltingly, figuring her way into life as an artist. And then she meets Eric, a digital archivist with a family in New Jersey, including an autopsist wife who has agreed to an open marriage—with rules. As if navigating the constantly shifting landscapes of contemporary sexual manners and racial politics weren't hard enough, Edie finds herself unemployed and falling into Eric's family life, his home. She becomes a hesitant friend to his wife and a de facto role model to his adopted daughter. Edie is the only Black woman who young Akila knows. Razor-sharp, darkly comic, sexually charged, socially disruptive, Luster is a portrait of a young woman trying to make sense of her life in a tumultuous era. It is also a haunting, aching description of how hard it is to believe in your own talent and the unexpected influences that bring us into ourselves along the way.", "isbn": "9780385696005", - "thumbnail": "https://books.google.com/books/content?id=NFeTEAAAQBAJ&printsec=frontcover&img=1&zoom=1&source=gbs_api", + "thumbnail": "https://books.google.com/books/content?id=pUmNEAAAQBAJ&printsec=frontcover&img=1&zoom=1&source=gbs_api", "title": "Luster", }, ] @@ -153,12 +153,12 @@ describe("index", () => { "description": "NEW YORK TIMES BESTSELLER Winner of the 2020 Center for Fiction First Novel Prize Winner of the 2020 National Book Critics Circle's John Leonard Prize for Best First Book Winner of the 2020 Kirkus Prize for Fiction Winner of the 2021 Dylan Thomas Prize Finalist for the 2021 PEN/Hemingway Award for Best First Novel Longlisted for the 2021 Andrew Carnegie Medal for Excellence in Fiction Longlisted for the 2021 PEN/Jean Stein Book Award Longlisted for the 2021 Women's Prize for Fiction A New York Times Notable Book of the Year Named Best Book of the Year by O: the Oprah Magazine, Vanity Fair, Los Angeles Times, Town and Country, Amazon, Indigo, NPR, Harper’s Bazaar, Kirkus Reviews, Marie Claire, Good Housekeeping Sharp, comic, disruptive, and tender, Luster sees a young Black woman fall into art and someone else's open marriage. Edie is stumbling her way through her twenties—sharing a subpar apartment in Bushwick, clocking in and out of her admin job, making a series of inappropriate sexual choices. She's also, secretly, haltingly, figuring her way into life as an artist. And then she meets Eric, a digital archivist with a family in New Jersey, including an autopsist wife who has agreed to an open marriage—with rules. As if navigating the constantly shifting landscapes of contemporary sexual manners and racial politics weren't hard enough, Edie finds herself unemployed and falling into Eric's family life, his home. She becomes a hesitant friend to his wife and a de facto role model to his adopted daughter. Edie is the only Black woman who young Akila knows. Razor-sharp, darkly comic, sexually charged, socially disruptive, Luster is a portrait of a young woman trying to make sense of her life in a tumultuous era. It is also a haunting, aching description of how hard it is to believe in your own talent and the unexpected influences that bring us into ourselves along the way.", "isbn": "9780385696005", "language": "en", - "link": "https://books.google.com/books/about/Luster.html?hl=&id=NFeTEAAAQBAJ", + "link": "https://books.google.com/books/about/Luster.html?hl=&id=pUmNEAAAQBAJ", "pageCount": 0, "printType": "BOOK", "publishedDate": "2020-08-04", "status": "started", - "thumbnail": "https://books.google.com/books/content?id=NFeTEAAAQBAJ&printsec=frontcover&img=1&zoom=1&source=gbs_api", + "thumbnail": "https://books.google.com/books/content?id=pUmNEAAAQBAJ&printsec=frontcover&img=1&zoom=1&source=gbs_api", "title": "Luster", }, ], @@ -404,37 +404,37 @@ describe("index", () => { }); await read(); expect(exportVariableSpy.mock.calls).toMatchInlineSnapshot(` - [ - [ - "BookStatus", - "want to read", - ], - [ - "BookNeedsReview", - true, - ], - [ - "BookMissingMetadata", - "pageCount", - ], - [ - "BookIsbn", - "9780385696005", - ], - [ - "BookTitle", - "Luster", - ], - [ - "BookThumbOutput", - "book-9780385696005.png", - ], - [ - "BookThumb", - "https://books.google.com/books/content?id=NFeTEAAAQBAJ&printsec=frontcover&img=1&zoom=1&source=gbs_api", - ], - ] - `); +[ + [ + "BookStatus", + "want to read", + ], + [ + "BookNeedsReview", + true, + ], + [ + "BookMissingMetadata", + "pageCount", + ], + [ + "BookIsbn", + "9780385696005", + ], + [ + "BookTitle", + "Luster", + ], + [ + "BookThumbOutput", + "book-9780385696005.png", + ], + [ + "BookThumb", + "https://books.google.com/books/content?id=NFeTEAAAQBAJ&printsec=frontcover&img=1&zoom=1&source=gbs_api", + ], +] +`); expect(setFailedSpy).not.toHaveBeenCalled(); expect(returnWriteFile.mock.calls[0]).toMatchInlineSnapshot(` [ @@ -578,7 +578,7 @@ describe("index", () => { "description": "NEW YORK TIMES BESTSELLER Winner of the 2020 Center for Fiction First Novel Prize Winner of the 2020 National Book Critics Circle's John Leonard Prize for Best First Book Winner of the 2020 Kirkus Prize for Fiction Winner of the 2021 Dylan Thomas Prize Finalist for the 2021 PEN/Hemingway Award for Best First Novel Longlisted for the 2021 Andrew Carnegie Medal for Excellence in Fiction Longlisted for the 2021 PEN/Jean Stein Book Award Longlisted for the 2021 Women's Prize for Fiction A New York Times Notable Book of the Year Named Best Book of the Year by O: the Oprah Magazine, Vanity Fair, Los Angeles Times, Town and Country, Amazon, Indigo, NPR, Harper’s Bazaar, Kirkus Reviews, Marie Claire, Good Housekeeping Sharp, comic, disruptive, and tender, Luster sees a young Black woman fall into art and someone else's open marriage. Edie is stumbling her way through her twenties—sharing a subpar apartment in Bushwick, clocking in and out of her admin job, making a series of inappropriate sexual choices. She's also, secretly, haltingly, figuring her way into life as an artist. And then she meets Eric, a digital archivist with a family in New Jersey, including an autopsist wife who has agreed to an open marriage—with rules. As if navigating the constantly shifting landscapes of contemporary sexual manners and racial politics weren't hard enough, Edie finds herself unemployed and falling into Eric's family life, his home. She becomes a hesitant friend to his wife and a de facto role model to his adopted daughter. Edie is the only Black woman who young Akila knows. Razor-sharp, darkly comic, sexually charged, socially disruptive, Luster is a portrait of a young woman trying to make sense of her life in a tumultuous era. It is also a haunting, aching description of how hard it is to believe in your own talent and the unexpected influences that bring us into ourselves along the way.", "isbn": "9780385696005", "language": "en", - "link": "https://books.google.com/books/about/Luster.html?hl=&id=NFeTEAAAQBAJ", + "link": "https://books.google.com/books/about/Luster.html?hl=&id=pUmNEAAAQBAJ", "pageCount": 0, "printType": "BOOK", "publishedDate": "2020-08-04", @@ -587,7 +587,7 @@ describe("index", () => { "new", "recommend", ], - "thumbnail": "https://books.google.com/books/content?id=NFeTEAAAQBAJ&printsec=frontcover&img=1&zoom=1&source=gbs_api", + "thumbnail": "https://books.google.com/books/content?id=pUmNEAAAQBAJ&printsec=frontcover&img=1&zoom=1&source=gbs_api", "title": "Luster", }, ],