fix: require rand feature when generating ecdsa key

Using `libp2p-identity` as a crate did not work if `default-features` is `false` and `ecdsa` is included. The following command also fails: ``` cargo check --no-default-features --features "ecdsa,ed25519,peerid,secp256k1" ``` Now, this command works Pull-Request: #5212.
libp2p · Jun 12, 2024 · 5089299 · 5089299
1 parent fc9b1ad
commit 5089299
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -84,7 +84,7 @@ libp2p-dns = { version = "0.41.1", path = "transports/dns" }
 libp2p-floodsub = { version = "0.44.0", path = "protocols/floodsub" }
 libp2p-gossipsub = { version = "0.46.2", path = "protocols/gossipsub" }
 libp2p-identify = { version = "0.44.2", path = "protocols/identify" }
-libp2p-identity = { version = "0.2.8" }
+libp2p-identity = { version = "0.2.9" }
 libp2p-kad = { version = "0.46.0", path = "protocols/kad" }
 libp2p-mdns = { version = "0.45.1", path = "protocols/mdns" }
 libp2p-memory-connection-limits = { version = "0.2.0", path = "misc/memory-connection-limits" }

diff --git a/identity/CHANGELOG.md b/identity/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.2.9
+
+- Add `rand` feature gate to ecdsa methods requiring a random number generator.
+  See [PR 5212](https://github.com/libp2p/rust-libp2p/pull/5212).
+
 ## 0.2.8
 
 - Bump `ring` to `0.17.5.

diff --git a/identity/Cargo.toml b/identity/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "libp2p-identity"
-version = "0.2.8"
+version = "0.2.9"
 edition = "2021"
 description = "Data structures and algorithms for identifying peers in libp2p."
 rust-version = "1.73.0" # MUST NOT inherit from workspace because we don't want to publish breaking changes to `libp2p-identity`.

diff --git a/identity/src/ecdsa.rs b/identity/src/ecdsa.rs
@@ -94,6 +94,7 @@ pub struct SecretKey(SigningKey);
 
 impl SecretKey {
     /// Generate a new random ECDSA secret key.
+    #[cfg(feature = "rand")]
     pub fn generate() -> SecretKey {
         SecretKey(SigningKey::random(&mut rand::thread_rng()))
     }