-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update async-io, if-addrs, env_logger #33
Conversation
None of these require any changes to the src of if-watch, as locally verified by building for the various target configs (linux, windows, iOS, macOS, and freebsd for "other"). They also don't impact the public API. async-io just released a 2.0.0 (https://github.com/smol-rs/async-io/releases/tag/v2.0.0) which offers saner dependencies and fixes an unsafety (which I don't claim is relevant to usage here, yet justifies async-io 2.0.0 adoption in general across the ecosystem). env_logger is a why-not since it can also be done without editing the src.
if-addrs 0.7 (the prior version) used winapi. if-addrs 0.8 moved to the official Windows bindings provided by Microsoft. 0.8 also included a bug fix. 0.9 added support for big-endian architectures.
Oh. I also debated updating rtnetlink (the remaining package with an incompatible update available). It can only be updated to 0.11, which added features not needed here. Updating to 0.12 would remove their use of re-exports, and require adding more crates to if-watch's Cargo.toml. I see no actual bug fixes present directly in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Would you mind bumping the patch version and adding a changelog entry?
Also, to make this easier on you, want to create a pull request adding @dependabot?
Minor version, given that we are > 1.0 |
@mxinden Friendly reminder I did bump the patch version and added a changelog entry, as requested :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the help.
Sorry for the delay.
The commit messages justify each change, though if the async-io update isn't preferable at this time, the if-addrs commit alone can be cherry-picked for the firm improvements provided.
I believe all this can fit in a patch release.