Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate from adal to azidentity for Azure kms #84

Open
sp98 opened this issue Mar 12, 2024 · 2 comments · May be fixed by #83
Open

migrate from adal to azidentity for Azure kms #84

sp98 opened this issue Mar 12, 2024 · 2 comments · May be fixed by #83

Comments

@sp98
Copy link

sp98 commented Mar 12, 2024

Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE REQUEST

What happened:
adal is out of support since March 31, 2023.
This PR migrates from adal to azidentity for azure key vault.
Migration guide was used as a reference.

What you expected to happen:
Ability to use azidentity library

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Container Orchestrator and version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@sp98 sp98 linked a pull request Mar 12, 2024 that will close this issue
Open
@sp98 sp98 changed the title migrate from adal to azidentity migrate from adal to azidentity for Azure kms Mar 12, 2024
@sp98
Copy link
Author

sp98 commented Mar 12, 2024

@adityadani Hello, I have PR opened for this feature request. Can you please take a look. Thanks.

@adityadani
Copy link
Collaborator

@sp98 Apologies for the delay. I have reviewed your PR and put some comments on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate from adal to azidentity sp98/secrets
2 participants
@adityadani @sp98