JNI Version 9 and 10

[nedtwigg]

It appears that packr currently supports only JNI Version 6 and 8

packr/PackrLauncher/src/main/cpp/packr.cpp

Lines 582 to 590 in 9c9bb9d

	if (hasJsonValue(jsonRoot, "jniVersion", sajson::TYPE_INTEGER)) {
	sajson::value jniVersion = getJsonValue(jsonRoot, "jniVersion");
	switch (jniVersion.get_integer_value()) {
	case 8:args.version = JNI_VERSION_1_8;
	break;
	default:args.version = JNI_VERSION_1_6;
	break;
	}
	}

packr/PackrLauncher/src/main/headers/packr.h

Lines 23 to 25 in 9c9bb9d

	#if !defined(JNI_VERSION_1_8)
	# define JNI_VERSION_1_8 0x00010008
	#endif

But there are now two newer versions (link). JNI_VERSION_10 is used for Java 10 through to at least 17.

#define JNI_VERSION_9   0x00090000
#define JNI_VERSION_10  0x000a0000

I haven't encountered any problems with this so far, but I know that I did need to set "jniVersion": 8 in my config.json. For people upgrading to newer JVMs, if you are encountering issues with JNI, you might want to investigate here.

[petoncle]

I did need to set "jniVersion": 8 in my config.json

Which Java version did you need to set it for?

[nedtwigg]

I originally needed to set it for Oracle JRE 8, and I am now using that same flag for AdoptOpenJdk 11, and it is working fine. I think most of my dependencies so far are still compiled to run against JRE 8, but I'm not sure. Perhaps the trouble won't come until those dependencies start requiring/compiling-against Java 11+?