New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3 compatibility of basestring checks #47

Open

kristoff-it wants to merge 1 commit into liberation:feature/django-19 from kristoff-it:feature/django-19

kristoff-it commented Jun 28, 2016

aliased ‘basestring’ with ‘str’ for py3 compatibility


          py3 compatibility of basestring checks

b94ed42

aliased ‘basestring’ with ‘str’ for py3 compatibility

Contributor

lauxley commented Jun 28, 2016

Hi, thx for the PR
I'm a little bit confused as to why merge this in feature/django-19 which is not py3 compatible ?
Also this is not the preferred way to deal with basestring according to django's documentation https://docs.djangoproject.com/en/1.9/topics/python3/#string-handling-with-six

isinstance(myvalue, six.string_types)       # replacement for basestring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet