Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust logging implementation #2

Open
jacobeva opened this issue May 20, 2024 · 4 comments
Open

Robust logging implementation #2

jacobeva opened this issue May 20, 2024 · 4 comments
Assignees

Comments

@jacobeva
Copy link

jacobeva commented May 20, 2024

The current logging implementation basically consists of a couple of Serial.prints on certain conditions.

A robust logging implementation similar to that of Meshtastic should be designed so as to allow for much easier debugging on the host side. Perhaps the RNode should send this over the serial interface following a certain set of bytes, which indicates to RNS this is a log message. Then, the message can be logged and more easily debugged.

Edit: Issue transferred from original at markqvist#69

@jacobeva
Copy link
Author

I say this is an important feature from experience ;)

@jacobeva
Copy link
Author

"While useful, I worry about the amount of memory the strings would take up. I'd also like to suggest this be a toggleable feature which defaults to off to keep serial traffic down. Still, could be quite useful if properly used." @faragher

@jacobeva
Copy link
Author

Indeed, PROGMEM should be used to minimise this. This should also be toggleable, I agree, whether it should be on or off by default is up for debate I suppose. I personally don't think it would be too hard on serial traffic, especially given most boards operate at 112500 nowadays.

@jacobeva
Copy link
Author

Perhaps a byte in the EEPROM for logging toggling is in order...

@jacobeva jacobeva self-assigned this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant