Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove llvm-strip pass from Makefile #161

Open
qmonnet opened this issue Sep 10, 2024 · 5 comments
Open

Remove llvm-strip pass from Makefile #161

qmonnet opened this issue Sep 10, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@qmonnet
Copy link
Member

qmonnet commented Sep 10, 2024 •
edited
Loading

[...] bpftool expects llvm-strip (for no good reason, anymore), so make sure you have that tool available.

[...] it would be nice to remove llvm-strip, bpftool gen object strips out DWARF already, so you shouldn't need extra stripping.

Originally posted by @anakryiko in libbpf/libbpf-bootstrap#286 (comment)
@qmonnet qmonnet added the enhancement New feature or request label Sep 10, 2024
@chentao-kernel
Copy link
Contributor

HI, qmonnet, you mean remove llvm-strip like this?
image

@qmonnet
Copy link
Member Author

qmonnet commented Sep 24, 2024

Yes I do 🙂

@chentao-kernel
Copy link
Contributor

It seems no one fix it in upstrem, i can send a ptach latter, do you think it's okay?

@qmonnet
Copy link
Member Author

qmonnet commented Sep 24, 2024

Absolutely. I planned to do it but I've been rather busy lately, so I won't do it this month. Go ahead, by all means!

intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Sep 24, 2024
@chentao-kernel @intel-lab-lkp
bpftool: Remove llvm-strip from Makefile
702dfeb 
As Quentin and Andrri said [0], bpftool gen object strips
out DWARF already, so remove the repeat operation.

[0] libbpf/bpftool#161

Suggested-by: Andrii Nakryiko <[email protected]>
Suggested-by: Quentin Monnet <[email protected]>
Signed-off-by: Tao Chen <[email protected]>
kernel-patches-daemon-bpf-rc bot pushed a commit to kernel-patches/bpf-rc that referenced this issue Sep 24, 2024
@chentao-kernel
bpftool: Remove llvm-strip from Makefile
0025638 
As Quentin and Andrri said [0], bpftool gen object strips
out DWARF already, so remove the repeat operation.

[0] libbpf/bpftool#161

Suggested-by: Andrii Nakryiko <[email protected]>
Suggested-by: Quentin Monnet <[email protected]>
Signed-off-by: Tao Chen <[email protected]>
kernel-patches-daemon-bpf bot pushed a commit to kernel-patches/bpf that referenced this issue Sep 24, 2024
@chentao-kernel
bpftool: Remove llvm-strip from Makefile
747cb7f 
As Quentin and Andrri said [0], bpftool gen object strips
out DWARF already, so remove the repeat operation.

[0] libbpf/bpftool#161

Suggested-by: Andrii Nakryiko <[email protected]>
Suggested-by: Quentin Monnet <[email protected]>
Signed-off-by: Tao Chen <[email protected]>
@qmonnet
Copy link
Member Author

qmonnet commented Sep 24, 2024

https://lore.kernel.org/all/[email protected]/t/#u

kernel-patches-daemon-bpf-rc bot pushed a commit to kernel-patches/bpf-rc that referenced this issue Sep 25, 2024
@chentao-kernel
bpftool: Remove llvm-strip from Makefile
62e2150 
As Quentin and Andrri said [0], bpftool gen object strips
out DWARF already, so remove the repeat operation.

[0] libbpf/bpftool#161

Suggested-by: Andrii Nakryiko <[email protected]>
Suggested-by: Quentin Monnet <[email protected]>
Signed-off-by: Tao Chen <[email protected]>
Acked-by: Quentin Monnet <[email protected]>
kernel-patches-daemon-bpf bot pushed a commit to kernel-patches/bpf that referenced this issue Sep 25, 2024
@chentao-kernel
bpftool: Remove llvm-strip from Makefile
fa0fea5 
As Quentin and Andrri said [0], bpftool gen object strips
out DWARF already, so remove the repeat operation.

[0] libbpf/bpftool#161

Suggested-by: Andrii Nakryiko <[email protected]>
Suggested-by: Quentin Monnet <[email protected]>
Signed-off-by: Tao Chen <[email protected]>
Acked-by: Quentin Monnet <[email protected]>
kernel-patches-daemon-bpf-rc bot pushed a commit to kernel-patches/bpf-rc that referenced this issue Sep 25, 2024
@chentao-kernel @borkmann
bpftool: Remove llvm-strip from Makefile
25bfc63 
As Quentin and Andrri said [0], bpftool gen object strips out DWARF
already, so remove the repeated operation.

  [0] libbpf/bpftool#161

Suggested-by: Andrii Nakryiko <[email protected]>
Suggested-by: Quentin Monnet <[email protected]>
Signed-off-by: Tao Chen <[email protected]>
Signed-off-by: Daniel Borkmann <[email protected]>
Acked-by: Quentin Monnet <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qmonnet @chentao-kernel