Add symbol size to Sym type #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change we expose the symbol's size in the form of the newly added Sym::size member, if it is available. Currently the only symbolization source that does not expose the size is kallsyms. Signed-off-by: Daniel Müller <[email protected]>
danielocfb
force-pushed
the
topic/sym-size
branch
from
9e37e40
to
d231d60
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 85.54% 89.46% +3.91%
==========================================
Files 37 37
Lines 4627 4640 +13
==========================================
+ Hits 3958 4151 +193
+ Misses 669 489 -180
☔ View full report in Codecov by Sentry. |
This patch changes the symbol used for testing purposes in the ELF demangle test from Normalizer::new to Normalizer::normalize_user_addrs_sorted. The former has been seen to be reported as Inspector::new on release builds, which has the exact same body and may be merged as an optimization. Signed-off-by: Daniel Müller <[email protected]>
|
The CI failure is due to: What I think is happening here is that because |
danielocfb
force-pushed
the
topic/sym-size
branch
from
325f7ca
to
6bf34fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we expose the symbol's size in the form of the newly added Sym::size member, if it is available. Currently the only symbolization source that does not expose the size is kallsyms.