Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Patmos platform on static-schedule-single-thread branch by direct Makefile #2315

Conversation

EhsanKhodadad
Copy link
Collaborator

No description provided.

@schoeberl
Copy link
Collaborator

In general, as it is mostly Patmos-specific changes, it looks fine. However, 2 points: (1) should a change in core/threaded/scheduler_static.c really be part of this commit? @lsk567 needs to approve those changes. (2) is test/C the best place for Patmos-specific README and Makefile?

@EhsanKhodadad
Copy link
Collaborator Author

EhsanKhodadad commented Jun 10, 2024

In general, as it is mostly Patmos-specific changes, it looks fine. However, 2 points: (1) should a change in core/threaded/scheduler_static.c really be part of this commit? @lsk567 needs to approve those changes. (2) is test/C the best place for Patmos-specific README and Makefile?

About core/threaded/scheduler_static.c, we only needed to comment out #include "semaphore.h" in line 55 to get rid of a compile error; other changes are made by the formatter.
Regarding the README and Makefile places, since we already had README files in both root and test directories, I decided to put them in the test/C directory because it was not only near the root but also near C/src/static/Patmos. Nevertheless, I will move them if you have other opinions or suggestions.

@lhstrh lhstrh requested a review from edwardalee June 10, 2024 15:11
@lsk567
Copy link
Collaborator

lsk567 commented Jun 13, 2024

@EhsanKhodadad Thanks for working on the Patmos support and get them to work with the static scheduler. However, I don't think these files belong in this lingua-franca repository. They seem to belong to the reactor-c repository.

Suggestions for a proper integration:

  • lf_patmos_support.c and lf_patmos_support.h belong to reactor-c/low_level_platform. Here is a FlexPRET example.
  • The Makefile and README should go into a separate template repo, such as this Pico template.

But given that this branch for single-threaded execution is not a stable solution (code from the threaded folder is leaking into single-threaded code), I suggest we not merge static-schedule-single-threaded into static-schedule or master. All the changes can park on this branch or a separate repo for this upcoming paper.

Then, we can work on the proper Patmos integration when we can print static schedules into a main() function. Therefore, I suggest we come back to this PR later.

@EhsanKhodadad EhsanKhodadad force-pushed the static-schedule-single-thread branch from dba3117 to 27ef659 Compare July 23, 2024 09:41
@lhstrh lhstrh added the feature New feature label Aug 2, 2024
@lhstrh
Copy link
Member

lhstrh commented Aug 2, 2024

Is PR still relevant considering there is #2383? Can it be closed?

@lhstrh lhstrh changed the title Support for Patmos platform EDIT ME: Some feature related to Patmos Aug 2, 2024
@EhsanKhodadad EhsanKhodadad changed the title EDIT ME: Some feature related to Patmos Support for Patmos platform on static-schedule-single-thread branch by direct Makefile Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants