Broken compatibility with Symfony 4.4 in 2.18

[jakubtobiasz]

Hello,
today, I've noticed 2.18 breaks compatibility with Symfony 4.4 by introducing ApiPlatformOpenApiPass. It fails because on Symfony 4.4 there's no security.firewalls parameter, so the whole pass is skipped. Inside it sets some arguments on the lexik_jwt_authentication.api_platform.openapi.factory service. When this compiler pass is skipped, the 3 of 4 arguments are null in this service definition. It results in the following error:

I see three options:
a) Check if security.firewalls parameter exists, if not set it
b) Drop support for Symfony 4.4 (bad idea as it's a minor version)
c) Remove this service in the pass when the parameter doesn't exist

[chalasr]

Hi, apologies for the super late reply.
Option c) looks sensible to me. Would you mind sending a PR?

[jakubtobiasz]

I'll try to find some spare time to fix this :).

[chalasr]

Cool :) Feel free to ping me on the symfony-devs slack anytime

[chalasr]

Friendly ping