Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework configuration #17

Open
jcjones opened this issue Aug 18, 2021 · 2 comments
Open

Rework configuration #17

jcjones opened this issue Aug 18, 2021 · 2 comments

Comments

@jcjones
Copy link
Collaborator

jcjones commented Aug 18, 2021

There's some inconsistent type checking here. Consider a library like Cerberus (https://github.com/pyeve/cerberus) which allows you to describe a config schema, enforce types, and define default setters where you need to merge values from args and yaml conditionally. You'll get consistent warning when a required input is of the wrong type or not present at all and it can be configured to purge data that's not part of the schema.

Originally posted by @beautifulentropy in #4 (comment)

@jcjones
Copy link
Collaborator Author

jcjones commented Aug 18, 2021

Also tackle #4 (comment)

@jcjones
Copy link
Collaborator Author

jcjones commented Aug 18, 2021

Also rehome it, per #4 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant