Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings for initialization of global variables with CreateRegion and too long string literals #12

Open
tdauth opened this issue Dec 23, 2024 · 2 comments

Comments

@tdauth
Copy link

tdauth commented Dec 23, 2024

Could you add warnings for two issues with JASS and Reforged/TFT: https://www.hiveworkshop.com/threads/list-of-warcraft-iii-crashes.194706/page-4#post-3637812

The first one is this:

globals
    region r = CreateRegion()
endglobals

which is valid syntax but leads to the game crashing when saving it.

The second one is:

return "hhgiuqvycdmnndtyhcjyvngtwjeykxtngnzfwndeeiytcgduquhdghfhvkguujibvqhpbrnfuqxqrctivvgmwtigpdxgdvaxubtmbievdkbmjmmmibawhbawkwdiyjnpjfgthutaykhzgyipmzecbpzqrtbhpkhuhiyjemptjpypyjdkkxjqcmejenpeajabvbkfufiyzvizgvqxyztutjrfxqrhvtueqccfkvbvqpvfxckumwiqjmzjyypuuugnkrbjtjjvzidavcxzntpnayufkqjirivaakutxmxcvjvyvgzdqjqtmkwvkqyjmjvpfciizgdrbnzwmqcjkqedepuvptfagtfvnuxtycefqhqfqjnvdecazzgnwyrniwmzpdnerxpqwwiwwwwfnefhgxpczuudxahafjpxgzmpdtpdwgruqtbmiqiumxdaevnbqifhafghdyjwhycmhygudfptvbjbqtnkvcryhqffqyxjvucjzmawmfieaztkikrmehvygynrkwmwgupgwhffwarvyfvejncwydwkfbeygvrzfazzdbzqxgpzpppqwbpunwmcxigfudfacfvwbjipgdedwyfqidrriwvyvtfgcfwarwtdrqzffivxudqnqrrtipnuvjuvbnnggxdcaderxbvzfbprkmamxzgivwrabdajqhkexdrqttfqebmbrejdpxkubwuxnthraukyrrfjjzmwnaiddamcbhfnrxqxznmvcrjhpybbhcnxdiymiyjgivendvenbajfmfvmrxepbevcqvujvzirgjmpucbuhyebfywiitqxkehqmtqypjtzyfwmvhqbwicgaygzvqrnzfzevgjrgdgzzdzhnatyxdmdgrpghnkimffigpmxazqkbvahdrzetzzemvwakpruqxyunukjvbztyzefgwjfehweubeijbvzynfurfyqprhagkrfkgfwardfjwdyxnicfvzccrijmtecghzyrfixhxggzqvmujnuzdpixgyqmrem"

which made the old World Editor crash according to https://www.hiveworkshop.com/threads/documentation-string-type.240473/ but not anymore and leads to save games crashing.
Any string literal should not be longer than 1023 characters.

I am sure there are more issues like this and warnings would be quite useful.

@lep
Copy link
Owner

lep commented Dec 23, 2024

I'll take your word on these.
e8cb077

@tdauth
Copy link
Author

tdauth commented Dec 24, 2024

"String literals over 1023 chars long crash the game upon saving." not on saving but loading the save game (with Reforged).

It crashed the World Editor on saving in TFT but not Reforged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants