Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider Input Not Full Component Width (Regression in 15.5) #1214

Closed
kdagnan opened this issue Jul 26, 2022 · 3 comments
Closed

Slider Input Not Full Component Width (Regression in 15.5) #1214

kdagnan opened this issue Jul 26, 2022 · 3 comments
Labels
Documentation Issues that require documentation updates

Comments

@kdagnan
Copy link

kdagnan commented Jul 26, 2022

Not sure how to word this (videos below), but essentially our slider input can only be dragged in a small portion of the displayed slider. The range/steps are the same as expected, but for some reason don't take up the full width of the component.

Works as intended in 15.4:
https://user-images.githubusercontent.com/44090970/181095668-7da03df5-5ae0-4fb1-9020-bad55512e8a0.mov

Behavior seen in 15.5 or greater:
https://user-images.githubusercontent.com/44090970/181095679-aeb37932-39a1-452b-ad50-275297268672.mov

Any ideas what could have changed this behavior and/or what I can do to fix it?

Didn't provide any implementation details because we're quite literally just passing standard options (min, max, step, start, etc) to noUiSlider.create. Other components are just aligned properly to make it look fancy on top. We copy/pasted the default styles at some point (and are overriding separately as necessary), but it doesn't look like those have changed.

@kdagnan
Copy link
Author

kdagnan commented Jul 26, 2022

Update: Actually it was the minor css changes -
Screen Shot 2022-07-26 at 2 57 56 PM

Release notes should point out stuff like that, I had to manually compare the branches & try the changes.

Thank you for a great package!

@kdagnan kdagnan closed this as completed Jul 26, 2022
@leongersen leongersen reopened this Jul 27, 2022
@leongersen leongersen added the Documentation Issues that require documentation updates label Jul 27, 2022
@leongersen
Copy link
Owner

Yeah, this is unfortunate; I'm sorry you ran into this issue. #1167 is open with some more discussion on this. I'll update the release notes to make this clearer.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Issues that require documentation updates
Projects
None yet
Development

No branches or pull requests

2 participants