Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to include not only the dependents, but also the dependencies #99

Open
BenjaBobs opened this issue Oct 14, 2024 · 3 comments
Open

Comments

@BenjaBobs
Copy link

Our team uses dotnet-affected ( ❤️ ) to only built/test/deploy the affected projects in our monorepo.

However due to various small issues between the dotnet tools (build/test/publish) and traversal files, we output the affected projects as .txt, and use that to create a new affected.sln.
It turns out that not all properties (e.g. configuration) are passed properly to all built projects when building a solution file whose projects have dependencies that are not also in the solution file, see dotnet/sdk#25973.

For that reason we also manually construct an affected_with_dependencies.sln using dotnet list reference.

If dotnet-affected could do this with a flag it would greatly simplify (and probably speed up) our CI pipeline.

Thanks for your time and hard work so far.

@leonardochaia
Copy link
Owner

Hi @BenjaBobs, thanks for reaching out.

I think this should be easy to implement since we already have some code to generate Solution files for testing. However, we also use dotnet-affected to buld/test/publish against the resulting traversal SDK file.

due to various small issues between the dotnet tools (build/test/publish) and traversal files

Would you mind clarifying which are the small issues you guys are facing when using the traversal SDK project? curious to know cause this may be affecting other users of the tool as well.

Thank you,
Leo.

@BenjaBobs
Copy link
Author

BenjaBobs commented Oct 14, 2024

Yes sure!
It seems that I miss-remembered, and it was actually only dotnet format that didn't work with .proj files.
dotnet/sdk#42296

If build/test/publish all work with proj files, and properly propagate --configuration Release and --runtime linux-x64 and the likes, then it this might not even be necessary.

@leonardochaia
Copy link
Owner

Hi @BenjaBobs , I think it would be nice if dotnet format plays good citizen and supports .proj files. I will take a look to the dotnet format code and see if I can implement it.

If that does not work we can support outputting a solution in dotnet affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants