-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix security vulnerabilities #18
Comments
For what it's worth, I have fork at https://github.com/cipater/graphql-persisted-document-loader that ditches I believe it also fixes #5 |
Thanks for that @cipater. I have a question, what exactly does that piece from thanks |
@kbariotis It adds the __typename field to your queries: https://github.com/leoasis/graphql-persisted-document-loader/blob/master/README.md |
Fixed by #23 |
This webpack loader depends on persistgraphql which is deprecated and has seen no update since 2018. As this also results in transitive dependencies with security vulnerabilities (e.g. yargs-parser) we should search for an alternative approach.
I am not quite sure why persistgraphql is used, as we only need to hash the output of graphql-tag/loader. To generate the hash from the query AST we could use the print method from graphql.
The text was updated successfully, but these errors were encountered: