Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent null checks #33

Open
b4yuan opened this issue Aug 23, 2023 · 1 comment
Open

Inconsistent null checks #33

b4yuan opened this issue Aug 23, 2023 · 1 comment

Comments

@b4yuan
Copy link

b4yuan commented Aug 23, 2023

symbol = scope_add_symbol(lemon,

lemon/lib/os.c

Line 369 in b1bb8a6

tmobject = lobject_create(lemon, sizeof(struct ltmobject), ltmobject_method);

symbol = scope_add_symbol(lemon, lemon->l_global, name, SYMBOL_GLOBAL);

frame = machine_peek_frame(lemon);

The functions called in these lines are consistently checked for null except in these instances. The lack of a null check could mask bugs.

@zhicheng
Copy link
Contributor

Hi, good catch, I'm currently working on something else, sorry for really long wait of response(not login github for years). you're right about issues, but it's may wait a while to fix issues, if you can provide pull requests, would be really good. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants