Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loaders should make temp files with non-colliding names and clean up after themselves #164

Open
adf-ncgr opened this issue Jun 20, 2024 · 3 comments

Comments

@adf-ncgr
Copy link

/tmp/temp.gff3 is one example, I think I ran into another too.

@svengato
Copy link

I have tentatively added a concluding tempfile.delete(); to the following files.

lis-bio-sources/lis-annotation/src/main/java/org/intermine/bio/dataconversion/AnnotationFileConverter.java
lis-bio-sources/lis-markers/src/main/java/org/intermine/bio/dataconversion/MarkerGFF3FileConverter.java
java/ncgr/datastore/src/main/java/org/ncgr/datastore/validation/AnnotationCollectionValidator.java 
java/ncgr/datastore/src/main/java/org/ncgr/datastore/validation/SyntenyCollectionValidator.java

@adf-ncgr
Copy link
Author

looks like this package is also implicated: https://github.com/ncgr/java/blob/main/datastore/src/main/java/org/ncgr/datastore/validation/AnnotationCollectionValidator.java
note that this is in the ncgr github, though I'm guessing probably only for historical reasons. Would probably be good to refactor so that it is handled like other libs and not with odd little scripts like update-ncgr-libs.sh. But since I've now lost a good chunk of time today trying to figure out where a reference to /tmp/temp.gff was still coming in even after I tried switching to use of java.nio.file.Files.createTempFile I think I'm not going to tackle that just now...

@svengato
Copy link

I fixed the "clean up after themselves" part in commit e9332c2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants