-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managing file I/O and Overwrites #4
Comments
About handling IO in the dataflow manager: right now we do not read/write the entire files all at once, but in chunks of ~3000 waveforms at a time. As a result, it's not clear to me how a raw_to_dsp as a table_in to table_out function will work. The current pseudocode for raw_to_dsp is:
If we want the dataflow manager to handle the IO steps, it will have to handle that full loop. That also means it will have to interact with the processing chain and not just the input and output tables, meaning raw_to_dsp under this proposal would have to also return the processing chain. |
These should both be handled with the refactor. Let's keep this open then come back to it then. |
in lh5.store.write() for append or overwrite mode we need to check if an object being written is going to be the new element of a struct (or column of a table, etc) and update the corresponding attribute. |
This is a continuation of a conversation from pull request 153 legend-exp/pygama#153
Summary:
@sweigart made the overwrite option act as expected for raw_to_dsp. However, ultimately we want to make a few more changes:
If I missed anything important in this summary please add on to it!
The text was updated successfully, but these errors were encountered: