Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Don't apply ambient occlusion to direct lighting #416

Open
1 task
kanerogers opened this issue Jan 27, 2023 · 0 comments
Open
1 task

[Bug] Don't apply ambient occlusion to direct lighting #416

kanerogers opened this issue Jan 27, 2023 · 0 comments
Labels
rendering An issue with the rendering system

Comments

@kanerogers
Copy link
Collaborator

Background

As @rasmusgo mentioned in #415 , we shouldn't be applying Ambient Occlusion to direct lights. I mean, it's right there in the name ambient, but I shouldn't be expected to read words or apply their meanings correctly. So I checked the spec, and (emphasis mine)..

The occlusion texture; it indicates areas that receive less indirect lighting from ambient sources. Direct lighting is not affected

Okay then. Guess we better fix it.

TODO

  • Remove ambient occlusion value from direct lighting calculations
@kanerogers kanerogers self-assigned this Feb 23, 2023
@kanerogers kanerogers moved this to 🔖 Ready in Hotham 0.3 Feb 23, 2023
@kanerogers kanerogers added the rendering An issue with the rendering system label Feb 23, 2023
@kanerogers kanerogers removed their assignment Feb 23, 2023
kanerogers added a commit that referenced this issue Mar 15, 2023
- AO should not be used in punctual lights

Closes #416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rendering An issue with the rendering system
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant