From a5fb6fd11c260d0596a0bc12bb8913b02d4500cf Mon Sep 17 00:00:00 2001 From: Erik Huelsmann Date: Sun, 22 Oct 2023 11:47:31 +0200 Subject: [PATCH] Invert the 'testing-done' condition because skipping indicates success, even if preceded by a failing job... --- .github/workflows/main.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index c05370c08e..8b6f47bd35 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -522,10 +522,13 @@ jobs: testing-done: runs-on: ubuntu-latest needs: [ test-database, test-pure-perl, test-remainder, test-webservices ] + if: failure() + # This job gets skipped on successful completion of the dependent jobs + # Skipped jobs are interpreted as 'success' condition in branch protection rules... steps: - - name: Done + - name: Failed run: | - echo "DONE!" + exit 1 build-dev: if: github.event.pull_request.merged == true