From 2697096d615e1c0617661a6386d605ef22447262 Mon Sep 17 00:00:00 2001 From: Erik Huelsmann Date: Sun, 22 Oct 2023 14:24:31 +0200 Subject: [PATCH] Invert the 'testing-done' condition Because skipping indicates success, even if preceded by a failing job... --- .github/workflows/main.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 72de6711b1..b72558f5a6 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -338,10 +338,13 @@ jobs: testing-done: runs-on: ubuntu-latest needs: [ build ] + if: failure() + # This job gets skipped on successful completion of the dependent jobs + # Skipped jobs are interpreted as 'success' condition in branch protection rules... steps: - - name: Done + - name: Failed run: | - echo "DONE!" + exit 1 build-dev: if: github.event.action == 'closed' && github.event.pull_request.merged == true