Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build binary even if :path is specified #99

Open
own2pwn opened this issue Oct 23, 2019 · 4 comments
Open

Build binary even if :path is specified #99

own2pwn opened this issue Oct 23, 2019 · 4 comments

Comments

@own2pwn
Copy link

own2pwn commented Oct 23, 2019

Looks like there's a check that will pass building if :path option is set. It would be nice to support builds even for local pods

@JanC
Copy link

JanC commented Feb 11, 2020

Hey,
I'd be also interested if local pods could be prebuilt as well. Would it be just a matter of removing this local check?
Update: I just tried and there seem to be other things preventing a local pod from prebuilding

@bclymer
Copy link

bclymer commented Feb 28, 2020

I was able to prebuild local pods by removing the check that OP mentioned, as well as commenting out these 2 lines.

all = all.reject {|pod_target| sandbox.local?(pod_target.pod_name) }

targets = targets.reject {|pod_target| sandbox.local?(pod_target.pod_name) }

Those were both added in the same commit, and based on the commit message it seems like it was done in order to prevent local pods from being built when you're using the "build all as binary" flag. Which, is a reasonable check to do. But obviously just creating another flag to make that behavior optional would have been ideal.

Hope it helps.

Obviously I don't understand the other potential implications of these changes, so use at your own risk.

EDIT: Still some issues with that approach. I'm seeing the assembled .framework bundles in the _Prebuild directory but the frameworks aren't included in the Pods project. I'll keep digging :\

@JanC
Copy link

JanC commented Feb 28, 2020

EDIT: Still some issues with that approach. I'm seeing the assembled .framework bundles in the _Prebuild directory but the frameworks aren't included in the Pods project. I'll keep digging :\

I was going to ask that :)

I think it should be something in Integration.rb to be changed so that those build .frameworks also get integrated in the xc project

@sueLan
Copy link

sueLan commented Jul 6, 2020

I also removed this two lines of code. And, I can install local development pod

return if standard_sanbox.local? self.name

next if self.sandbox.local?(root_name)

But, it seems it is by design that it doesn't support development pods. #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants