Flakey manage tokens test

[kyranjamie]

Running into this test failure on CI and local, but only very occasionally. It runs and then just kinda stops dead.

x in ~/dev/leather/extension                                                                      ±[●229][feat/bns-v2]
❯ p playwright test specs/manage-tokens/manage-tokens.spec.ts
[WebServer] [webpack-cli] No need to use the 'serve' command together with '{ watch: true | false }' or '--watch'/'--no-watch' configuration, it does not make sense.
[WebServer] <i> [webpack-dev-server] Project is running at:
[WebServer] <i> [webpack-dev-server] Loopback: http://localhost:3000/
[WebServer] <i> [webpack-dev-server] On Your Network (IPv4): http://192.168.0.142:3000/
[WebServer] <i> [webpack-dev-server] On Your Network (IPv6): http://[fe80::1]:3000/
[WebServer] <i> [webpack-dev-server] Content not from webpack is served from '/Users/kyranjamie/dev/leather/extension/public' directory
[WebServer] <i> [webpack-dev-server] 404s will fallback to '/index.html'

Running 1 test using 1 worker

  ✘  1 …ge-tokens/manage-tokens.spec.ts:18:8 › Manage tokens › that token can be removed from asset list and added back (15.4s)


  1) [chromium] › specs/manage-tokens/manage-tokens.spec.ts:18:8 › Manage tokens › that token can be removed from asset list and added back

    Error: Timed out 5000ms waiting for expect(locator).not.toBeAttached()

    Locator: getByTestId('asset-list').getByTestId('SP265WBWD4NH7TVPYQTVD23X3607NNK4484DTXQZ3.longcoin::longcoin')
    Expected: not attached
    Received: attached
    Call log:
      - expect.not.toBeAttached with timeout 5000ms
      - waiting for getByTestId('asset-list').getByTestId('SP265WBWD4NH7TVPYQTVD23X3607NNK4484DTXQZ3.longcoin::longcoin')
      -   locator resolved to <div class="leather-my_space.02" data-testid="SP265WBWD4NH7TVPYQTVD23X3607NNK4484DTXQZ3.longcoin::longcoin">…</div>
      -   unexpected value "true"
      -   locator resolved to <div class="leather-my_space.02" data-testid="SP265WBWD4NH7TVPYQTVD23X3607NNK4484DTXQZ3.longcoin::longcoin">…</div>
      -   unexpected value "true"
      -   locator resolved to <div class="leather-my_space.02" data-testid="SP265WBWD4NH7TVPYQTVD23X3607NNK4484DTXQZ3.longcoin::longcoin">…</div>
      -   unexpected value "true"
      -   locator resolved to <div class="leather-my_space.02" data-testid="SP265WBWD4NH7TVPYQTVD23X3607NNK4484DTXQZ3.longcoin::longcoin">…</div>
      -   unexpected value "true"
      -   locator resolved to <div class="leather-my_space.02" data-testid="SP265WBWD4NH7TVPYQTVD23X3607NNK4484DTXQZ3.longcoin::longcoin">…</div>
      -   unexpected value "true"
      -   locator resolved to <div class="leather-my_space.02" data-testid="SP265WBWD4NH7TVPYQTVD23X3607NNK4484DTXQZ3.longcoin::longcoin">…</div>
      -   unexpected value "true"
      -   locator resolved to <div class="leather-my_space.02" data-testid="SP265WBWD4NH7TVPYQTVD23X3607NNK4484DTXQZ3.longcoin::longcoin">…</div>
      -   unexpected value "true"
      -   locator resolved to <div class="leather-my_space.02" data-testid="SP265WBWD4NH7TVPYQTVD23X3607NNK4484DTXQZ3.longcoin::longcoin">…</div>
      -   unexpected value "true"
      -   locator resolved to <div class="leather-my_space.02" data-testid="SP265WBWD4NH7TVPYQTVD23X3607NNK4484DTXQZ3.longcoin::longcoin">…</div>
      -   unexpected value "true"


      56 |
      57 |     // test that tokens are disabled
    > 58 |     await expect(sip10InAssetList).not.toBeAttached();
         |                                        ^
      59 |     await expect(brc20InAssetList).not.toBeAttached();
      60 |     await expect(src20InAssetList).not.toBeAttached();
      61 |     await expect(stx20InAssetList).not.toBeAttached();

        at /Users/kyranjamie/dev/leather/extension/tests/specs/manage-tokens/manage-tokens.spec.ts:58:40

  Slow test file: [chromium] › specs/manage-tokens/manage-tokens.spec.ts (15.4s)
  Consider splitting slow test files to speed up parallel execution
  1 failed
    [chromium] › specs/manage-tokens/manage-tokens.spec.ts:18:8 › Manage tokens › that token can be removed from asset list and added back

To open last HTML report run:

  pnpm exec playwright show-report

[linear]

LEA-1730 Flakey manage tokens test

[camerow]

Should this get worked on next cycle @kyranjamie?

[kyranjamie]

Absolutely, yeah. Has been causing issues. cc @alter-eggo who's been fighting with this

[alter-eggo]

I fixed flaky test, though in a bit "hacky" way, problem there is not in a test itself, bug with wrong default switch value might happen in the wallet, though in a rare case, when user opens manage tokens very fast once opens the wallet and needed data is not there.

we need to add some loaders there, will take a look into it later

[kyranjamie]

Updated issue title to reflect this