You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The amount of decimals for an ERC20 token depends on the value stored in the smart contract. In the burner wallet we just assume that any ERC20 token has the same amount of decimals as Ether.
Slightly off-topic as your issue is about the code assuming similarity of ERC20 token and ETH in terms of decimals but I think if web3 was differently build, we could change this easily:
I looked into the web3 documentation of fromWei but unfortunately it just allows conversion based on Ethereum unit names "szabo", "wei", etc., while a conversion based on the decimal number would make much more sense to me personally.
I wish there was a function like fromWei(<num>, 18)...
The amount of decimals for an ERC20 token depends on the value stored in the smart contract. In the burner wallet we just assume that any ERC20 token has the same amount of decimals as Ether.
plasma-burner-wallet/src/App.js
Line 386 in 75e3e38
The text was updated successfully, but these errors were encountered: