ci: speedup ci for feature branches #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought circleci's caching worked by exact matching the cache key, however, after seeing the ci not updating the cache I learned that the key is prefix matched. Changed so that it appends the time to the cache for unique cache keys. I've also added the branch name to the cache to avoid cache trashing.
Hyxogen
force-pushed
the
feat-faster-ci
branch
from
371a695 to
080ce2a
Compare
yuri91
requested changes
Nov 24, 2023
Hyxogen
force-pushed
the
feat-faster-ci
branch
from
080ce2a to
f972d4e
Compare
yuri91
approved these changes
Nov 24, 2023
Apparently, the working directory is different for when running check and check-llvm, thus try both possible locations for test1.ll. This change will make the ci run about ~50 tests less than when running with all tests with the "check" rule. These tests are for llvm-lit.
Hyxogen
force-pushed
the
feat-faster-ci
branch
from
9c58416 to
f51f481
Compare
|
Is this ready now? |
|
@yuri91 If all passes then it should be good. And yes, it contains the PR about the cache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge this PR after #182
This PR has a few optimizations to the ci on feature branches, speeding it up to about 30 minutes total.
These are mostly low hanging fruit like:
There's still some other low hanging fruit out there, like: