CodeGen: fix crash when using allocations in global initializer #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, EmitCheerpBuiltinExpr would assume that CurDeclFunc would never be null, which isn't the when it is a global, causing dyn_cast to trigger an assert. The same was true for calloc and realloc.
|
Still running my asan tests, will mark for review when those pass |
When compiling for target cheerp, there's an error for when not explicitly casting the return type of an allocation. However code execution relying on the explicit cast AST Node still continues after the diagnostic is reported, resulting in a nullptr deref.
yuri91
approved these changes
Nov 17, 2023
yuri91
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
EmitCheerpBuiltinExprwould assume thatCurDeclFuncwould never be null, which isn't the when it is a global, causingdyn_castto trigger an assert. The same was true for calloc and realloc.