Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mising header #160

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

Hyxogen
Copy link
Contributor

@Hyxogen Hyxogen commented Sep 26, 2023

The file cheerpintrin.h uses size_t, but the necessary header for it is not included.

@yuri91
Copy link
Member

yuri91 commented Sep 26, 2023

maybe we should instead not use size_t but unsigned int in those two places.
This header is automatically included everywhere, so I don't like it to bring other stuff with it.

@Hyxogen
Copy link
Contributor Author

Hyxogen commented Sep 26, 2023

This header is automatically included everywhere, so I don't like it to bring other stuff with it.

Any (working) code already includes one or more of these headers:

  • cstddef
  • cstdio
  • cstring
  • ctime
  • cuchar
  • cwchar

Or otherwise it would not compile because of those size_t. So I don't think it brings that much other stuff with it

@yuri91
Copy link
Member

yuri91 commented Sep 26, 2023

that's true. And it's not automatically included, just the search path for it is.

So I guess it's ok to add the include

@yuri91 yuri91 self-requested a review September 26, 2023 09:58
@alexp-sssup alexp-sssup merged commit 246ea48 into leaningtech:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants