Move memory allocation from Wasm to js #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maqrkk
force-pushed
the
move-memory-allocation
branch
from
7af0116 to
9bd87ff
Compare
yuri91
approved these changes
Sep 25, 2023
|
@Maqrkk This PR breaks support for memory exporting, that is used for CJ3 and CX |
Previously, memory was allocated in Wasm and then exported to js. Now, in preparation for threading, we allocate the memory in js and then import it in Wasm.
Maqrkk
force-pushed
the
move-memory-allocation
branch
from
9bd87ff to
d943e45
Compare
yuri91
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, memory was allocated in Wasm and then exported to js. Now, in preparation for threading, we allocate the memory in js and then import it in Wasm.