Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove whitespace replacement from Android runner #2437

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

piotruela
Copy link
Collaborator

@piotruela piotruela commented Nov 28, 2024

This PR reverts a change made here. It was previously required as androidx.test:orchestrator:1.5.0 introduced a regression which was later reverted in androidx.test:orchestrator:1.5.1.

Also I updated the setup instructions to suggest using the latest version of the orchestrator.

Added a check if we are running on Orchestrator 1.5.0. If we detect this version, we warn user about that version

Copy link

docs-page bot commented Nov 28, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/leancodepl/patrol~2437

Documentation is deployed and generated using docs.page.

@github-actions github-actions bot added package: patrol Related to the patrol package (native automation, test bundling) docs Concerns doc comments, READMEs, or docs package: patrol_cli Related to the patrol_cli package labels Nov 28, 2024
Copy link
Collaborator

@pdenert pdenert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piotruela piotruela force-pushed the feat/test-name-whitespace branch from a559adb to 179e790 Compare December 6, 2024 13:25
@piotruela piotruela force-pushed the feat/test-name-whitespace branch from 82c8904 to 0696e82 Compare December 6, 2024 13:39
@piotruela piotruela merged commit f03675e into master Dec 6, 2024
16 of 18 checks passed
@piotruela piotruela deleted the feat/test-name-whitespace branch December 6, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Concerns doc comments, READMEs, or docs package: patrol_cli Related to the patrol_cli package package: patrol Related to the patrol package (native automation, test bundling)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants