Make short error messages descriptive in iOS reports

[fylyppo]

This issue has been edited by me (@bartekpacia)

Expected behavior

Reproduce:

1. Make one test failing
2. Run the failing test locally on iOS Simulator (patrol test -t integration_test/failing_test.dart)
3. After run finishes, open xcresult report.

Result

Actual behavior

Reproduce

1. Make one test failing
2. Run the failing test on BrowserStack
3. After run, check logs or open xcresult report.
4. Notice that cause of test failure is not present

More context

I run my tests on Browserstack and when I look into xcresult file there's only a short message per test case. This is very annoying.

More random ideas:

• Piece of code responsible for this ugly error message.
• Maybe we can swap XCTAssertTrue with XCTFail? @bartekpacia: We tried this and it didn't change anything.

[fylyppo]

To compare instrumentation logs (only me and @bartekpacia ([email protected]) has access):

• expected behaviour instumentation logs from Swift app and ios_report.zip
• behaviour when you run test on BS from Flutter app and patrol test and ios_report.zip

[bartekpacia]

To reproduce build of the native iOS app run any native iOS app with a one failing test, for example browserstack/xcuitest-sample-browserstack (modify code to make test failing). Make sure to run on XCUITest v2 API (the one that uses XCTestPlans).

To reproduce build of the Flutter app:

1. Install Flutter SDK
2. Install Patrol CLI: dart pub global activate patrol_cli
3. Clone this repository: git clone git clone [email protected]:leancodepl/patrol.git, cd packages/patrol/example.
4. Make sure the app builds fine for iOS device: flutter build ios --release. Fix any code signing issues that might arise.
5. Upload the Flutter app and instrumentation build to BrowserStack using our bs_ios. It can be installed with brew tap leancodepl/tools && brew install mobile-tools.

Please ask in case of any questions, we're be happy to help.

For BrowserStack people: see also #1923

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.