Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patrol CLI doesn't support --dart-define-from-file #1742

Closed
bartekpacia opened this issue Sep 22, 2023 · 6 comments · Fixed by #2232
Closed

Patrol CLI doesn't support --dart-define-from-file #1742

bartekpacia opened this issue Sep 22, 2023 · 6 comments · Fixed by #2232
Assignees
@pdenert
Labels
feature New feature request package: patrol_cli Related to the patrol_cli package

Comments

@bartekpacia
Copy link
Contributor

See discussion in #1477, especially this comment.

If we want to be consistent with Flutter, we should wait for flutter/flutter#130599 to be resolved.
@bartekpacia bartekpacia added feature New feature request package: patrol_cli Related to the patrol_cli package blocked Blocked by external factors labels Sep 22, 2023
@bartekpacia bartekpacia mentioned this issue Sep 22, 2023
Closed
@vital-edu
Copy link

flutter/flutter#130599 was resolved. I assume this means the blocked label can removed from this issue.

@bartekpacia
Copy link
Contributor Author

bartekpacia commented Oct 25, 2023 •
edited
Loading

That's right - thanks!

Although it's not that simple:

  • we still need to wait for it to land on the latest stable Flutter
  • even when new stable Flutter is released, we need to support a few older stable releases as well

@bartekpacia bartekpacia removed the blocked Blocked by external factors label Oct 25, 2023
@bartekpacia
Copy link
Contributor Author

Our new min is 3.16, this is unblocked now.

@kane-knowby
Copy link

Any chance this is being worked on soon? I'm trying to evaluate whether we can use Patrol for our project and currently this is a blocker

@piotruela piotruela mentioned this issue May 2, 2024
Closed
@jay-athelas
Copy link

no update so far?

@pdenert pdenert self-assigned this Jun 13, 2024
@jBorkowska jBorkowska mentioned this issue Jun 18, 2024
Closed
@pdenert pdenert mentioned this issue Jun 19, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pdenert pdenert

Labels
feature New feature request package: patrol_cli Related to the patrol_cli package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dart define from file leancodepl/patrol
5 participants
@vital-edu @pdenert @bartekpacia @kane-knowby @jay-athelas