Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headerBuilder and footerBuilder expect slivers which is not obvious #30

Closed
piotruela opened this issue Jun 28, 2024 · 0 comments · Fixed by #40
Closed

headerBuilder and footerBuilder expect slivers which is not obvious #30

piotruela opened this issue Jun 28, 2024 · 0 comments · Fixed by #40
Assignees
@Xezolpl

Comments

@piotruela
Copy link
Collaborator

PaginatedCubitLayout takes headerBuilder and footerBuilder as parameters but it's not clear from the outside that both widgets should be a sliver. I think they should be named headerSliverBuilder and footerSliverBuilder as for example in NestedScrollView
@Xezolpl Xezolpl self-assigned this Nov 12, 2024
@Xezolpl Xezolpl linked a pull request Nov 12, 2024 that will close this issue
Rename PaginatedCubitLayout parameters #40
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xezolpl Xezolpl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename PaginatedCubitLayout parameters leancodepl/leancode_cubit_utils
2 participants
@piotruela @Xezolpl