Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOSS Review] Repository License Issues #17

Closed
CameronDevine opened this issue Jan 30, 2024 · 3 comments
Closed

[JOSS Review] Repository License Issues #17

CameronDevine opened this issue Jan 30, 2024 · 3 comments

Comments

@CameronDevine
Copy link

As part of the JOSS review, openjournals/joss-reviews#6138, this repository needs to have an OSI approved license. While this repository does have a license listed, I am worried about the license issues of including the KUKA FRI SDK in this repository.

This also appears to be related to #6 and #14. Please fix this issue using at least one of the methods suggested in your existing issues.
@mhubii
Copy link
Member

mhubii commented Feb 3, 2024

hi @CameronDevine , just saw your first reviews. Thank you very much, I really appreciate it! Will try to fix those, so we can improve this software :)

@mhubii
Copy link
Member

mhubii commented Feb 3, 2024

Putting for reference https://joss.readthedocs.io/en/latest/review_criteria.html#software-license

mhubii added a commit to lbr-stack/lbr_fri_ros2_stack that referenced this issue Feb 5, 2024
@mhubii
changed license lbr-stack/fri#17
575b1b2
mhubii added a commit to lbr-stack/lbr_fri_ros2_stack that referenced this issue Feb 5, 2024
@mhubii
add ap2 license lbr-stack/fri#17
b59922c
mhubii added a commit to lbr-stack/fri_vendor that referenced this issue Feb 5, 2024
@mhubii
Delete LICENSE lbr-stack/fri#17
2af4685
mhubii added a commit to lbr-stack/fri_vendor that referenced this issue Feb 5, 2024
@mhubii
add ap2 license lbr-stack/fri#17
1e753b7
mhubii added a commit that referenced this issue Feb 5, 2024
@mhubii
added notice #17
c055474
@mhubii
Copy link
Member

mhubii commented Feb 5, 2024

added notice https://github.com/lbr-stack/fri/blob/fri-1.15/NOTICE

@mhubii mhubii closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CameronDevine @mhubii