Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some l3build configs are not used on CI #1536

Open
muzimuzhi opened this issue Nov 4, 2024 · 3 comments
Open

Some l3build configs are not used on CI #1536

muzimuzhi opened this issue Nov 4, 2024 · 3 comments

Comments

@muzimuzhi
Copy link
Contributor

I find some l3build configs are not used on CI, thus the tests are not checked by CI.

Among them, base/config-lttemplates.lua will be added if PR #1534 gets merged. The remaining are

# not added to "checkconfigs" in corresponding build.lua, and
# not covered by job matrixes in main.yaml and pretest.yaml
base/config-broken.lua
base/config-filenames.lua
base/config-search.lua
required/latex-lab/config-OR-local.lua
required/latex-lab/config-TU.lua
required/latex-lab/config-math-tagging-examples.lua
required/tools/config-broken.lua

# not added to "checkconfigs" in required/firstaid/build.lua
required/firstaid/config-local.lua
required/firstaid/config-pdf.lua

I guess the two config-broken.lua should not be checked, as suggested by there names.

Note that base/config-filenames.lua sets testfiledir = "testfiles-filenames" but the corresponding directory base/testfiles-filenames doesn't exist. There's only base/testfiles-filename (without the trailing "s").

@josephwright
Copy link
Member

I've merged #1534

@josephwright
Copy link
Member

Sorted?

@muzimuzhi
Copy link
Contributor Author

If any configs listed in the code block in #1536 (comment) need to be tested, then no, not sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants