[vscode][5/n] Setup Env Variables: Read the text from the env template and append to existing file #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 21, 2024 19:58
This PR I had some issues with reading the env template, so for now I'm splitting up this logic and will follow up next PR ## Test Plan https://github.com/lastmile-ai/aiconfig/assets/151060367/6aad117f-0c55-4549-8f46-1b438c6ebf4b
…e and append to existing file TSIA, and making the function async now that we call an await statement ## Test Plan https://github.com/lastmile-ai/aiconfig/assets/151060367/6679e13d-6d58-4ec4-a237-360cb273e59c
rossdanlm
requested review from
saqadri,
rholinshead,
suyoglastmileai,
Ankush-lastmile and
jonathanlastmileai
as code owners
| // }); | ||
| const helperText = ( | ||
| await vscode.workspace.fs.readFile(envTemplatePath) | ||
| ).toString(); |
There was a problem hiding this comment.
nice! using const instead of let
|
|
||
| // TODO: Check if we already appended the template text to existing .env | ||
| // file before. If we did, don't do it again | ||
| fs.appendFile(envPath, helperText, function (err) { | ||
| fs.appendFile(envPath, "\n\n" + helperText, function (err) { |
There was a problem hiding this comment.
nit: define \n\n as a constant
saqadri
approved these changes
Feb 22, 2024
|
|
||
| // TODO: Check if we already appended the template text to existing .env | ||
| // file before. If we did, don't do it again | ||
| fs.appendFile(envPath, "\n\n" + helperText, function (err) { |
There was a problem hiding this comment.
This is fine for now, but if a file already exists perhaps we should ask the user to specify a different file or ask them if they want to overwrite or append. Can be a future improvement.
There was a problem hiding this comment.
I'm going to push back saying this is P1 and focus more on content for tonight. If I have time before midnight I'll do it
Ankush-lastmile
approved these changes
Feb 22, 2024
rossdanlm
added a commit
that referenced
this pull request
Feb 22, 2024
…th (#1284) [vscode][4/n] Setup Env Variables: Add helper text to existing env path This PR I had some issues with reading the env template, so for now I'm splitting up this logic and will follow up next PR ## Test Plan https://github.com/lastmile-ai/aiconfig/assets/151060367/6aad117f-0c55-4549-8f46-1b438c6ebf4b --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1284). * #1285 * __->__ #1284 * #1283 * #1280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[vscode][5/n] Setup Env Variables: Read the text from the env template and append to existing file
TSIA, and making the function async now that we call an await statement
Test Plan
06dbbee1-9e3c-441f-8a5c-2391ba661481.mp4
Stack created with Sapling. Best reviewed with ReviewStack.