-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize ad banner on screen orientation change #55
Comments
Have you tried setting a new width/height/AdRequest and then reloading the banner? |
I have played around with this but without success because the ad size is set once in the "init()" (respectively "initInternal()" (patch) method. |
Do you want to to take a look on this, or shall I provide a patch? |
Ah I see - you're absolutely right. I think the problem, then, is that it requires a full banner initialization - which earlier (back when I first wrote the code) would crash. I can see that we call Destroy safely now - but I'm not sure it can be re-initialized a second time. You are welcome to provide a patch - watch out for issue #11 |
On iOS (probably also Android) the ad banner does not adapt to a change in the view's width or height properties. The ad banner view should issue a new ad request in case the width or height changes. As an alternative (or better addition) it would be useful to manually tell the ad banner view to send a new ad request.
The text was updated successfully, but these errors were encountered: