Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite 5 Compatibility #11

Closed
alejo-moreno opened this issue Jan 22, 2024 · 4 comments
Closed

Vite 5 Compatibility #11

alejo-moreno opened this issue Jan 22, 2024 · 4 comments

Comments

@alejo-moreno
Copy link

When trying to install the plugin in a Vite 5 project there's a dependency conflict

$ npm i -D vite-plugin-twig-drupal
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/vite
npm ERR!   dev vite@"^5.0.8" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer vite@"^4.4.11" from [email protected]
npm ERR! node_modules/vite-plugin-twig-drupal
npm ERR!   dev vite-plugin-twig-drupal@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Thanks for the help.

@larowlan
Copy link
Owner

#12

@larowlan
Copy link
Owner

https://github.com/larowlan/vite-plugin-twig-drupal/releases/tag/v1.2.0

@alejo-moreno
Copy link
Author

That was awesome timing response, thanks @larowlan , i'll be able to propose a new theme to my team using vite+storybook+Drupal.
One minor additional thing i had to do after upgrading was converting the config to ESM otherwise it throws an error when storybook starts, here's the doc: https://vitejs.dev/guide/troubleshooting.html#config

@larowlan
Copy link
Owner

No worries, I default to ESM nowadays so didn't notice that but thanks for pointing out for others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants