Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulse is ignoring timezone setting #410

Closed
maciek-szn opened this issue Sep 30, 2024 · 4 comments · Fixed by #417
Closed

Pulse is ignoring timezone setting #410

maciek-szn opened this issue Sep 30, 2024 · 4 comments · Fixed by #417
Assignees

Comments

@maciek-szn
Copy link

Pulse Version

1.2.5

Laravel Version

11.25.0

PHP Version

8.3.10

Livewire Version

3.5.8

Database Driver & Version

No response

Description

After updating Laravel to version 11, Pulse stopped honoring the timezone setting. This may be due to updating Carbon to version 3. Data is presented according to UTC time zone, even though the time zone is set to "Europe/Warsaw" (both in Laravel and PHP configuration).

Steps To Reproduce

Set your Laravel timezone to something other than "UTC" and observe the timeline in your Pulse charts.

@timacdonald
Copy link
Member

Hi, @maciek-szn, thanks for reporting this. I've just some testing and wanted to confirm what I'm seeing is what you are reporting.

I can see that everything still works as expected. The graphs still show the right data in the right places, e.g., data from "now" is always at the right-hand side.

The problem being that when you hover over the dates is you see UTC time in the browser rather than your own timezone.

You would like to see Warsaw's time in this popup, i.e., 2024-10-02 00:36:00 rather than the same time but in UTC format.

Screenshot 2024-10-02 at 08 37 39

@timacdonald
Copy link
Member

I feel that we should likely display the time in your browsers timezone, rather than the applications timezone - potentially with UTC alongside.

@timacdonald timacdonald self-assigned this Oct 1, 2024
@maciek-szn
Copy link
Author

You would like to see Warsaw's time in this popup, i.e., 2024-10-02 00:36:00 rather than the same time but in UTC format.

Indeed. In Laravel 10 (i.e. Carbon 2) everything works fine. I didn't look into the code, but maybe that's the reason.

@timacdonald
Copy link
Member

Closing this one as we have a PR open for this: #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants