NewCommand does not check for herd valet existence

[Anticom]

Installer Version

5.8.1

Description

620f1b3 introduced automatic inference of TLD in case either herd or valet is present on the host machine.
However this method does not check for existence of those tools first, causing the following error to be thrown when generating a new laravel application:

In Process.php line 371:

  The command "'herd' 'tld' '-v'" failed.

  Working directory: /path/to/workingdirectory

  Error: proc_open(): posix_spawn() failed: No such file or directory

Not only is this bad UX but most improtantly this causes laravel new to exit with a non-zero code. This may break scripts created by user automating project scaffolding.

Steps To Reproduce

1. Make sure neither herd nor valet is on your host system
2. run laravel new foo
3. choose default options for promts

[driesvints]

cc @xiCO2k: could you maybe send a fix for this one?

[Anticom]

Additional info:
I also just noticed NewCommand does not appear to run to completion. I chose to initialize the git repo for me which did not happen.

[Anticom]

I re-ran the command with very verbose output, yielding

In Process.php line 371:

  [Symfony\Component\Process\Exception\ProcessStartFailedException]
  The command "'herd' 'tld' '-v'" failed.

  Working directory: /path/to/workingdirectory

  Error: proc_open(): posix_spawn() failed: No such file or directory


Exception trace:
  at /Users/anticom/.composer/vendor/symfony/process/Process.php:371
 Symfony\Component\Process\Process->start() at /Users/anticom/.composer/vendor/symfony/process/Process.php:249
 Symfony\Component\Process\Process->run() at /Users/anticom/.composer/vendor/laravel/installer/src/NewCommand.php:766
 Laravel\Installer\Console\NewCommand->getTld() at /Users/anticom/.composer/vendor/laravel/installer/src/NewCommand.php:751
 Laravel\Installer\Console\NewCommand->generateAppUrl() at /Users/anticom/.composer/vendor/laravel/installer/src/NewCommand.php:185
 Laravel\Installer\Console\NewCommand->execute() at /Users/anticom/.composer/vendor/symfony/console/Command/Command.php:279
 Symfony\Component\Console\Command\Command->run() at /Users/anticom/.composer/vendor/symfony/console/Application.php:1029
 Symfony\Component\Console\Application->doRunCommand() at /Users/anticom/.composer/vendor/symfony/console/Application.php:316
 Symfony\Component\Console\Application->doRun() at /Users/anticom/.composer/vendor/symfony/console/Application.php:167
 Symfony\Component\Console\Application->run() at /Users/anticom/.composer/vendor/laravel/installer/bin/laravel:13
 include() at /Users/anticom/.composer/vendor/bin/laravel:119

Looking at Process.php:371 a ProcessStartFailedException is thrown there:

        // ...
        if (!\is_resource($process)) {
            throw new ProcessStartFailedException($this, $lastError);
        }
        // ...

[xiCO2k]

On it

[xiCO2k]

PR: #343