🧑‍💻 Request for Channel Webhook Integration

[marky291]

We would like to request the implementation of a webhook integration feature that leverages the existing channel->webhooks() functionality provided by DiscordPHP. This integration is sought to enhance our application's connectivity and streamline our notification processes.

[marky291]

Code snippet of how I am using it with DiscordPHP, cannot find a simple solution to this. :(

`if ($messageCache->count()) {

            $messageItem = $messageCache->pop();

            $this->discord()->getChannel($messageItem->getChannelId())->webhooks->freshen()->done(function (WebhookRepository $webhooks) use ($messageItem) {

                $message = MessageBuilder::new()->setUsername($messageItem->getUsername())->setContent($messageItem->getMessage());

                $webhook = $webhooks->find(function (Webhook $webhook) {
                    return $webhook->name === config('services.discord.bot_name');
                });

                // async function.
                if (!$webhook) {
                    $webhooks->save(new Webhook($this->discord(), [
                        'name' => config('services.discord.bot_name'),
                    ]))->then(function (Webhook $webhook) use ($message, $messageItem) {
                        $webhook->execute($message)->done(function (Message $message) use ($messageItem) {
                            Log::info('Message sent: ' . $message->content . ' to channel ' . $messageItem->getChannelId());
                        });
                    });
                }

                // this if a webhook already exists, since not async.
                $webhook->execute($message)->done(function (Message $message) use ($messageItem) {
                    Log::info('Message sent: ' . $message->content . ' to channel ' . $messageItem->getChannelId());
                });
            });`

[Log1x]

Hi! I moved this to the framework repo.

Can you give me a better example of how this would be used? I'm struggling to understand the purpose or how I could provide better DX for it.

[marky291]

Hey! Sorry, it looks like it is the only way to dynamically set the bot name when sending messages. This is really useful for when you want the bot to change name (Dynamic AI Characters) or for when you want to create chat between applications by using the logged in users name.

[Log1x]

Ideally we'd implement something like ->toWebhook($url) in https://github.com/laracord/framework/blob/main/src/Discord/Message.php to start.

I'd like to explore Webhook creation itself at a later date/in a separate issue.

[Log1x]

#73 proposes a solution to this. I ended up adding the webhook creation as it made sense in this case.

With the PR, your code would be reduced to something like:

if ($messageCache->isEmpty()) {
    return;
}

$messageItem = $messageCache->pop();

$this
    ->message()
    ->username($messageItem->getUsername())
    ->body($messageItem->getMessage())
    ->webhook()
    ->send($messageItem->getChannelId());